refactor(api, curriculum): use the shared shuffleArray util (#56444)

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

shared/utils/shuffle-array.ts

@@ -4,7 +4,10 @@ export const shuffleArray = <T>(arrToShuffle: Array<T>) => {
 
   for (let i = arr.length - 1; i > 0; i--) {
     const j = Math.floor(Math.random() * (i + 1));
-    [arr[i], arr[j]] = [arr[j], arr[i]];
+
+    // We know that i and j are within the bounds of the array, TS doesn't
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
+    [arr[i], arr[j]] = [arr[j]!, arr[i]!];
   }
 
   return arr;