refactor: remove isPrivate (#61952)

client/src/__mocks__/challenge-nodes.ts

@@ -7,7 +7,6 @@ interface MockChallengeNodes {
     id: string;
     block: string;
     title: string;
-    isPrivate: boolean;
     superBlock: string;
     dashedName: string;
   };
@@ -23,7 +22,6 @@ const mockChallengeNodes: MockChallengeNodes[] = [
       id: 'a',
       block: 'block-a',
       title: 'Challenge One',
-      isPrivate: false,
       superBlock: 'super-block-one',
       dashedName: 'challenge-one'
     }
@@ -37,7 +35,6 @@ const mockChallengeNodes: MockChallengeNodes[] = [
       id: 'b',
       block: 'block-a',
       title: 'Challenge Two',
-      isPrivate: false,
       superBlock: 'super-block-one',
       dashedName: 'challenge-two'
     }
@@ -51,7 +48,6 @@ const mockChallengeNodes: MockChallengeNodes[] = [
       id: 'c',
       block: 'block-b',
       title: 'Challenge One',
-      isPrivate: false,
       superBlock: 'super-block-one',
       dashedName: 'challenge-one'
     }
@@ -66,7 +62,6 @@ const mockChallengeNodes: MockChallengeNodes[] = [
       id: 'd',
       block: 'block-b',
       title: 'Challenge Two',
-      isPrivate: false,
       superBlock: 'super-block-one',
       dashedName: 'challenge-two'
     }
@@ -80,7 +75,6 @@ const mockChallengeNodes: MockChallengeNodes[] = [
       id: 'e',
       block: 'block-c',
       title: 'Challenge One',
-      isPrivate: true,
       superBlock: 'super-block-one',
       dashedName: 'challenge-one'
     }
@@ -94,7 +88,6 @@ const mockChallengeNodes: MockChallengeNodes[] = [
       id: 'f',
       block: 'block-a',
       title: 'Challenge One',
-      isPrivate: false,
       superBlock: 'super-block-two',
       dashedName: 'challenge-one'
     }
@@ -108,7 +101,6 @@ const mockChallengeNodes: MockChallengeNodes[] = [
       id: 'g',
       block: 'block-a',
       title: 'Challenge Two',
-      isPrivate: false,
       superBlock: 'super-block-two',
       dashedName: 'challenge-two'
     }
@@ -122,7 +114,6 @@ const mockChallengeNodes: MockChallengeNodes[] = [
       id: 'h',
       block: 'block-b',
       title: 'Challenge One',
-      isPrivate: false,
       superBlock: 'super-block-two',
       dashedName: 'challenge-one'
     }
@@ -136,7 +127,6 @@ const mockChallengeNodes: MockChallengeNodes[] = [
       id: 'i',
       block: 'block-b',
       title: 'Challenge Two',
-      isPrivate: false,
       superBlock: 'super-block-two',
       dashedName: 'challenge-two'
     }
@@ -150,7 +140,6 @@ const mockChallengeNodes: MockChallengeNodes[] = [
       id: 'j',
       block: 'block-a',
       title: 'Challenge One',
-      isPrivate: false,
       superBlock: 'super-block-three',
       dashedName: 'challenge-one'
     }
@@ -164,7 +153,6 @@ const mockChallengeNodes: MockChallengeNodes[] = [
       id: 'k',
       block: 'block-c',
       title: 'Challenge Two',
-      isPrivate: false,
       superBlock: 'super-block-three',
       dashedName: 'challenge-two'
     }
@@ -178,7 +166,6 @@ const mockChallengeNodes: MockChallengeNodes[] = [
       id: 'l',
       block: 'block-c',
       title: 'Challenge Three',
-      isPrivate: false,
       superBlock: 'super-block-three',
       dashedName: 'challenge-three'
     }
@@ -192,7 +179,6 @@ const mockChallengeNodes: MockChallengeNodes[] = [
       id: 'm',
       block: 'block-a',
       title: 'Challenge One',
-      isPrivate: false,
       superBlock: 'super-block-four',
       dashedName: 'challenge-one'
     }

client/src/redux/prop-types.ts

@@ -210,7 +210,6 @@ export type ChallengeNode = {
     notes: string;
     prerequisites: PrerequisiteChallenge[];
     isLocked: boolean;
-    isPrivate: boolean;
     order: number;
     questions: Question[];
     quizzes: Quiz[];

client/src/templates/Introduction/components/block.test.tsx

@@ -63,7 +63,6 @@ const defaultProps = {
       notes: 'mockNotes',
       prerequisites: [] as PrerequisiteChallenge[],
       isLocked: false,
-      isPrivate: false,
       order: 1,
       questions: [] as Question[],
       assignments: ['mockAssignment'],

client/utils/build-challenges.js

@@ -45,7 +45,6 @@ exports.buildChallenges = async function buildChallenges() {
     }, []);
 
   const builtChallenges = blocks
-    .filter(block => !block.isPrivate)
     .map(({ challenges }) => challenges)
     .reduce((accu, current) => accu.concat(current), []);
   return builtChallenges;

client/utils/gatsby/challenge-page-creator.js

@@ -102,8 +102,6 @@ exports.createChallengePages = function (
       id,
       isLastChallengeInBlock
     } = node.challenge;
-    // TODO: challengeType === 7 and isPrivate are the same, right? If so, we
-    // should remove one of them.
 
     createPage({
       path: slug,

curriculum/build-superblock.js

@@ -147,7 +147,6 @@ function addMetaToChallenge(challenge, meta) {
   challenge.superOrder = meta.superOrder;
   challenge.challengeOrder = challengeOrderIndex;
   challenge.isLastChallengeInBlock = isLastChallengeInBlock;
-  challenge.isPrivate = challenge.isPrivate || meta.isPrivate;
   challenge.required = (meta.required || []).concat(challenge.required || []);
   challenge.template = meta.template;
   challenge.helpCategory = challenge.helpCategory || meta.helpCategory;

curriculum/challenges/english/certifications/a1-professional-chinese.yml

@@ -3,7 +3,6 @@ id: 688f1daf0133dbe2a36b140b
 title: A1 Professional Chinese Certification
 certification: a1-professional-chinese-certification
 challengeType: 7
-isPrivate: true
 tests:
   - id: 688f1daf0133dbe2a36b140b
     title: "Dialogue 1: PLACEHOLDER"

curriculum/challenges/english/certifications/a2-english-for-developers.yml

@@ -3,7 +3,6 @@ id: 651dd7e01d697d0aab7833b7
 title: A2 English for Developers Certification
 certification: a2-english-for-developers
 challengeType: 7
-isPrivate: true
 tests:
   - id: 6721db5d9f0c116e6a0fe25a
     title: A2 English for Developers Certification Exam

curriculum/challenges/english/certifications/a2-professional-chinese.yml

@@ -3,7 +3,6 @@ id: 682c3153086dd7cabe7f48bc
 title: A2 Professional Chinese Certification
 certification: a2-professional-chinese-certification
 challengeType: 7
-isPrivate: true
 tests:
   - id: 682c2753317b88f1ecdad894
     title: "Dialogue 1: PLACEHOLDER"

curriculum/challenges/english/certifications/a2-professional-spanish.yml

@@ -3,7 +3,6 @@ id: 681a6b22e5a782fe3459984a
 title: A2 Professional Spanish Certification
 certification: a2-professional-spanish-certification
 challengeType: 7
-isPrivate: true
 tests:
   - id: 681a8796e5a782fe3459984b
     title: "Dialogue 1: PLACEHOLDER"

curriculum/challenges/english/certifications/b1-english-for-developers.yml

@@ -3,7 +3,6 @@ id: 66607e53317411dd5e8aae21
 title: B1 English for Developers Certification
 certification: b1-english-for-developers
 challengeType: 7
-isPrivate: true
 tests:
   - id: 66607e5b317411dd5e8aae22
     title: "Dialogue 1: I'm Tom"

curriculum/challenges/english/certifications/back-end-development-and-apis.yml

@@ -3,7 +3,6 @@ id: 561add10cb82ac38a17523bc
 title: Back End Development and APIs Certification
 certification: back-end-development-and-apis
 challengeType: 7
-isPrivate: true
 tests:
   - id: bd7158d8c443edefaeb5bdef
     title: Timestamp Microservice

curriculum/challenges/english/certifications/college-algebra-with-python.yml

@@ -3,7 +3,6 @@ id: 61531b20cc9dfa2741a5b800
 title: College Algebra with Python Certification
 certification: college-algebra-with-python
 challengeType: 7
-isPrivate: true
 tests:
   - id: 63d83ff239c73468b059cd3f
     title: Build a Multi-Function Calculator

curriculum/challenges/english/certifications/data-analysis-with-python.yml

@@ -2,7 +2,6 @@ id: 5e46fc95ac417301a38fb934
 title: Data Analysis with Python Certification
 certification: data-analysis-with-python
 challengeType: 7
-isPrivate: true
 tests:
   - id: 5e46f7e5ac417301a38fb928
     title: Mean-Variance-Standard Deviation Calculator

curriculum/challenges/english/certifications/data-visualization.yml

@@ -2,7 +2,6 @@ id: 5a553ca864b52e1d8bceea14
 title: Data Visualization Certification
 certification: data-visualization
 challengeType: 7
-isPrivate: true
 tests:
   - id: bd7168d8c242eddfaeb5bd13
     title: Visualize Data with a Bar Chart

curriculum/challenges/english/certifications/foundational-c-sharp-with-microsoft.yml

@@ -3,7 +3,6 @@ id: 647f7da207d29547b3bee1ba
 title: Foundational C# with Microsoft Certification
 certification: foundational-c-sharp-with-microsoft
 challengeType: 7
-isPrivate: true
 tests:
   - id: 647e22d18acb466c97ccbef8
     title: Foundational C# with Microsoft Certification Exam

curriculum/challenges/english/certifications/front-end-development-libraries.yml

@@ -3,7 +3,6 @@ id: 561acd10cb82ac38a17513bc
 title: Front End Development Libraries Certification
 certification: front-end-development-libraries
 challengeType: 7
-isPrivate: true
 tests:
   - id: bd7158d8c442eddfaeb5bd13
     title: Build a Random Quote Machine

curriculum/challenges/english/certifications/full-stack-developer.yml

@@ -3,7 +3,6 @@ id: 64514fda6c245de4d11eb7bb
 title: Certified Full Stack Developer
 certification: full-stack-developer
 challengeType: 7
-isPrivate: true
 tests:
   - id: 645147516c245de4d11eb7ba
     title: Certified Full Stack Developer Exam

curriculum/challenges/english/certifications/information-security.yml

@@ -2,7 +2,6 @@ id: 5e6021435ac9d0ecd8b94b00
 title: Information Security Certification
 certification: information-security
 challengeType: 7
-isPrivate: true
 tests:
   - id: 587d824a367417b2b2512c44
     title: Stock Price Checker

curriculum/challenges/english/certifications/javascript-algorithms-and-data-structures-v8.yml

@@ -2,7 +2,6 @@ id: 658180220947283cdc0689ce
 title: JavaScript Algorithms and Data Structures Certification
 certification: javascript-algorithms-and-data-structures-v8
 challengeType: 7
-isPrivate: true
 tests:
   - id: 657bdc55a322aae1eac3838f
     title: Build a Palindrome Checker

curriculum/challenges/english/certifications/javascript-algorithms-and-data-structures.yml

@@ -2,7 +2,6 @@ id: 561abd10cb81ac38a17513bc
 title: Legacy JavaScript Algorithms and Data Structures Certification
 certification: javascript-algorithms-and-data-structures
 challengeType: 7
-isPrivate: true
 tests:
   - id: aaa48de84e1ecc7c742e1124
     title: Palindrome Checker

curriculum/challenges/english/certifications/legacy-back-end.yml

@@ -2,7 +2,6 @@ id: 660add10cb82ac38a17513be
 title: Legacy Back End Certification
 certification: legacy-back-end
 challengeType: 7
-isPrivate: true
 tests:
   - id: bd7158d8c443edefaeb5bdef
     title: Timestamp Microservice

curriculum/challenges/english/certifications/legacy-data-visualization.yml

@@ -2,7 +2,6 @@ id: 561add10cb82ac39a17513bc
 title: Legacy Data Visualization Certification
 certification: legacy-data-visualization
 challengeType: 7
-isPrivate: true
 tests:
   - id: bd7157d8c242eddfaeb5bd13
     title: Build a Markdown Previewer

curriculum/challenges/english/certifications/legacy-front-end.yml

@@ -2,7 +2,6 @@ id: 561add10cb82ac38a17513be
 title: Legacy Front End Certification
 certification: legacy-front-end
 challengeType: 7
-isPrivate: true
 tests:
   - id: bd7158d8c242eddfaeb5bd13
     title: Build a Personal Portfolio Webpage

curriculum/challenges/english/certifications/legacy-full-stack.yml

@@ -2,7 +2,6 @@ id: 561add10cb82ac38a17213bd
 title: Legacy Full Stack Certification
 certification: legacy-full-stack
 challengeType: 7
-isPrivate: true
 tests:
   - id: 561add10cb82ac38a17513bc
     title: Responsive Web Design Certification

curriculum/challenges/english/certifications/legacy-information-security-and-quality-assurance.yml

@@ -2,7 +2,6 @@ id: 561add10cb82ac38a17213bc
 title: Legacy Information Security and Quality Assurance Certification
 certification: legacy-information-security-and-quality-assurance
 challengeType: 7
-isPrivate: true
 tests:
   - id: 587d8249367417b2b2512c41
     title: Metric-Imperial Converter

curriculum/challenges/english/certifications/machine-learning-with-python.yml

@@ -2,7 +2,6 @@ id: 5e46fc95ac417301a38fb935
 title: Machine Learning with Python Certification
 certification: machine-learning-with-python
 challengeType: 7
-isPrivate: true
 tests:
   - id: 5e46f8d6ac417301a38fb92d
     title: Rock Paper Scissors

curriculum/challenges/english/certifications/quality-assurance.yml

@@ -2,7 +2,6 @@ id: 5e611829481575a52dc59c0e
 title: Quality Assurance Certification
 certification: quality-assurance
 challengeType: 7
-isPrivate: true
 tests:
   - id: 587d8249367417b2b2512c41
     title: Metric-Imperial Converter

curriculum/challenges/english/certifications/relational-database.yml

@@ -2,7 +2,6 @@ id: 606243f50267e718b1e755f4
 title: Relational Database Certification
 certification: relational-database
 challengeType: 7
-isPrivate: true
 tests:
   - id: 5f1a4ef5d5d6b5ab580fc6ae
     title: Celestial Bodies Database

curriculum/challenges/english/certifications/responsive-web-design.yml

@@ -2,7 +2,6 @@ id: 561add10cb82ac38a17513bc
 title: Responsive Web Design Certification
 certification: responsive-web-design
 challengeType: 7
-isPrivate: true
 tests:
   - id: bd7158d8c442eddfaeb5bd18
     title: Build a Tribute Page

curriculum/challenges/english/certifications/scientific-computing-with-python.yml

@@ -2,7 +2,6 @@ id: 5e44431b903586ffb414c951
 title: Scientific Computing with Python Certification
 certification: scientific-computing-with-python
 challengeType: 7
-isPrivate: true
 tests:
   - id: 5e44412c903586ffb414c94c
     title: Arithmetic Formatter

curriculum/schema/challenge-schema.js

@@ -126,219 +126,216 @@ const quizJoi = Joi.object().keys({
     .required()
 });
 
-const schema = Joi.object()
+const schema = Joi.object().keys({
-  .keys({
+  block: Joi.string().regex(slugRE).required(),
-    block: Joi.string().regex(slugRE).required(),
+  blockId: Joi.objectId(),
-    blockId: Joi.objectId(),
+  blockType: Joi.when('superBlock', {
-    blockType: Joi.when('superBlock', {
+    is: [...chapterBasedSuperBlocks, ...catalogSuperBlocks],
-      is: [...chapterBasedSuperBlocks, ...catalogSuperBlocks],
+    then: Joi.valid(
-      then: Joi.valid(
+      'workshop',
-        'workshop',
+      'lab',
-        'lab',
+      'lecture',
-        'lecture',
+      'review',
-        'review',
+      'quiz',
-        'quiz',
+      'exam'
-        'exam'
-      ).required(),
-      otherwise: Joi.valid(null)
-    }),
-    blockLayout: Joi.valid(
-      'challenge-list',
-      'challenge-grid',
-      'dialogue-grid',
-      'link',
-      'project-list',
-      'legacy-challenge-list',
-      'legacy-link',
-      'legacy-challenge-grid'
     ).required(),
-    challengeOrder: Joi.number(),
+    otherwise: Joi.valid(null)
-    chapter: Joi.string().when('superBlock', {
+  }),
-      is: chapterBasedSuperBlocks,
+  blockLayout: Joi.valid(
-      then: Joi.required(),
+    'challenge-list',
-      otherwise: Joi.optional()
+    'challenge-grid',
-    }),
+    'dialogue-grid',
-    certification: Joi.string().regex(slugWithSlashRE),
+    'link',
-    challengeType: Joi.number().min(0).max(30).required(),
+    'project-list',
-    checksum: Joi.number(),
+    'legacy-challenge-list',
-    // TODO: require this only for normal challenges, not certs
+    'legacy-link',
-    dashedName: Joi.string().regex(slugRE),
+    'legacy-challenge-grid'
-    demoType: Joi.string().valid('onClick', 'onLoad'),
+  ).required(),
-    description: Joi.when('challengeType', {
+  challengeOrder: Joi.number(),
-      is: [
+  chapter: Joi.string().when('superBlock', {
-        challengeTypes.step,
+    is: chapterBasedSuperBlocks,
-        challengeTypes.video,
+    then: Joi.required(),
-        challengeTypes.multipleChoice,
+    otherwise: Joi.optional()
-        challengeTypes.fillInTheBlank
+  }),
-      ],
+  certification: Joi.string().regex(slugWithSlashRE),
-      then: Joi.string().allow(''),
+  challengeType: Joi.number().min(0).max(30).required(),
-      otherwise: Joi.string().required()
+  checksum: Joi.number(),
-    }),
+  // TODO: require this only for normal challenges, not certs
-    disableLoopProtectTests: Joi.boolean().required(),
+  dashedName: Joi.string().regex(slugRE),
-    disableLoopProtectPreview: Joi.boolean().required(),
+  demoType: Joi.string().valid('onClick', 'onLoad'),
-    explanation: Joi.when('challengeType', {
+  description: Joi.when('challengeType', {
-      is: [challengeTypes.multipleChoice, challengeTypes.fillInTheBlank],
+    is: [
-      then: Joi.string()
+      challengeTypes.step,
-    }),
+      challengeTypes.video,
-    challengeFiles: Joi.array().items(fileJoi),
+      challengeTypes.multipleChoice,
-    guideUrl: Joi.string().uri({ scheme: 'https' }),
+      challengeTypes.fillInTheBlank
-    hasEditableBoundaries: Joi.boolean(),
+    ],
-    helpCategory: Joi.valid(
+    then: Joi.string().allow(''),
-      'JavaScript',
+    otherwise: Joi.string().required()
-      'HTML-CSS',
+  }),
-      'Python',
+  disableLoopProtectTests: Joi.boolean().required(),
-      'Backend Development',
+  disableLoopProtectPreview: Joi.boolean().required(),
-      'C-Sharp',
+  explanation: Joi.when('challengeType', {
-      'English',
+    is: [challengeTypes.multipleChoice, challengeTypes.fillInTheBlank],
-      'Odin',
+    then: Joi.string()
-      'Euler',
+  }),
-      'Rosetta'
+  challengeFiles: Joi.array().items(fileJoi),
-    ),
+  guideUrl: Joi.string().uri({ scheme: 'https' }),
-    isLastChallengeInBlock: Joi.boolean().required(),
+  hasEditableBoundaries: Joi.boolean(),
-    videoUrl: Joi.string().allow(''),
+  helpCategory: Joi.valid(
-    fillInTheBlank: Joi.object().keys({
+    'JavaScript',
-      sentence: Joi.string().required(),
+    'HTML-CSS',
-      blanks: Joi.array()
+    'Python',
-        .items(
+    'Backend Development',
-          Joi.object().keys({
+    'C-Sharp',
-            answer: Joi.string().required(),
+    'English',
-            feedback: Joi.string().allow(null)
+    'Odin',
-          })
+    'Euler',
-        )
+    'Rosetta'
-        .required()
+  ).required(),
-    }),
+  isLastChallengeInBlock: Joi.boolean().required(),
-    forumTopicId: Joi.number(),
+  videoUrl: Joi.string().allow(''),
-    id: Joi.objectId().required(),
+  fillInTheBlank: Joi.object().keys({
-    instructions: Joi.string().when('challengeType', {
+    sentence: Joi.string().required(),
-      is: [challengeTypes.pythonProject, challengeTypes.codeAllyCert],
+    blanks: Joi.array()
-      then: Joi.string().min(1).required(),
-      otherwise: Joi.string().allow('')
-    }),
-    isComingSoon: Joi.bool(),
-    isLocked: Joi.bool(),
-    isPrivate: Joi.bool(),
-    module: Joi.string().when('superBlock', {
-      is: chapterBasedSuperBlocks,
-      then: Joi.required(),
-      otherwise: Joi.optional()
-    }),
-    msTrophyId: Joi.when('challengeType', {
-      is: [challengeTypes.msTrophy],
-      then: Joi.string().required()
-    }),
-    notes: Joi.string().allow(''),
-    order: Joi.number(),
-    prerequisites: Joi.when('challengeType', {
-      is: [challengeTypes.exam],
-      then: Joi.array().items(prerequisitesJoi)
-    }),
-    // video challenges only:
-    videoId: Joi.when('challengeType', {
-      is: [challengeTypes.video],
-      then: Joi.string().required()
-    }),
-    videoLocaleIds: Joi.when('challengeType', {
-      is: challengeTypes.video,
-      then: Joi.object().keys({
-        espanol: Joi.string(),
-        italian: Joi.string(),
-        portuguese: Joi.string()
-      })
-    }),
-    bilibiliIds: Joi.when('challengeType', {
-      is: challengeTypes.video,
-      then: Joi.object().keys({
-        aid: Joi.number().required(),
-        bvid: Joi.string().required(),
-        cid: Joi.number().required()
-      })
-    }),
-    questions: Joi.when('challengeType', {
-      is: [
-        challengeTypes.video,
-        challengeTypes.multipleChoice,
-        challengeTypes.theOdinProject
-      ],
-      then: Joi.array().items(questionJoi).min(1).required(),
-      otherwise: Joi.array().length(0)
-    }),
-    quizzes: Joi.when('challengeType', {
-      is: challengeTypes.quiz,
-      then: Joi.array().items(quizJoi).min(1).required(),
-      otherwise: Joi.forbidden()
-    }),
-    required: Joi.array().items(
-      Joi.object().keys({
-        link: Joi.string(),
-        raw: Joi.bool(),
-        src: Joi.string(),
-        crossDomain: Joi.bool()
-      })
-    ),
-    assignments: Joi.when('challengeType', {
-      is: challengeTypes.dialogue,
-      then: Joi.array().items(Joi.string()).required(),
-      otherwise: Joi.array().items(Joi.string())
-    }),
-    scene: Joi.object().keys({
-      setup: setupJoi.required(),
-      commands: Joi.array()
-        .items(commandJoi)
-        .unique(
-          (a, b) =>
-            a.dialogue &&
-            b.dialogue &&
-            !(
-              (a.startTime < b.startTime &&
-                a.finishTime < b.finishTime &&
-                a.finishTime <= b.startTime) ||
-              (b.startTime < a.startTime &&
-                b.finishTime < a.finishTime &&
-                b.finishTime <= a.startTime)
-            )
-        )
-        .messages({
-          'array.unique': 'Dialogues must not have overlapping times.'
-        })
-    }),
-    solutions: Joi.array().items(Joi.array().items(fileJoi).min(1)),
-    superBlock: Joi.string().regex(slugWithSlashRE),
-    superOrder: Joi.number(),
-    suborder: Joi.number(),
-    hooks: Joi.object().keys({
-      beforeAll: Joi.string().allow(''),
-      beforeEach: Joi.string().allow(''),
-      afterEach: Joi.string().allow('')
-    }),
-    tests: Joi.array()
       .items(
-        // public challenges
         Joi.object().keys({
-          id: Joi.string().allow(''),
+          answer: Joi.string().required(),
-          text: Joi.string().required(),
+          feedback: Joi.string().allow(null)
-          testString: Joi.string().allow('').required()
-        }),
-        // our tests used in certification verification
-        Joi.object().keys({
-          id: Joi.string().required(),
-          title: Joi.string().required()
         })
       )
-      .required(),
+      .required()
-    template: Joi.string().allow(''),
+  }),
-    title: Joi.string().required(),
+  forumTopicId: Joi.number(),
-    transcript: Joi.when('challengeType', {
+  id: Joi.objectId().required(),
-      is: [challengeTypes.generic, challengeTypes.video],
+  instructions: Joi.string().when('challengeType', {
-      then: Joi.string()
+    is: [challengeTypes.pythonProject, challengeTypes.codeAllyCert],
-    }),
+    then: Joi.string().min(1).required(),
-    translationPending: Joi.bool().required(),
+    otherwise: Joi.string().allow('')
-    url: Joi.when('challengeType', {
+  }),
-      is: [challengeTypes.codeAllyPractice, challengeTypes.codeAllyCert],
+  isComingSoon: Joi.bool(),
-      then: Joi.string().required()
+  isLocked: Joi.bool(),
-    }),
+  module: Joi.string().when('superBlock', {
-    usesMultifileEditor: Joi.boolean()
+    is: chapterBasedSuperBlocks,
-  })
+    then: Joi.required(),
-  .xor('helpCategory', 'isPrivate');
+    otherwise: Joi.optional()
+  }),
+  msTrophyId: Joi.when('challengeType', {
+    is: [challengeTypes.msTrophy],
+    then: Joi.string().required()
+  }),
+  notes: Joi.string().allow(''),
+  order: Joi.number(),
+  prerequisites: Joi.when('challengeType', {
+    is: [challengeTypes.exam],
+    then: Joi.array().items(prerequisitesJoi)
+  }),
+  // video challenges only:
+  videoId: Joi.when('challengeType', {
+    is: [challengeTypes.video],
+    then: Joi.string().required()
+  }),
+  videoLocaleIds: Joi.when('challengeType', {
+    is: challengeTypes.video,
+    then: Joi.object().keys({
+      espanol: Joi.string(),
+      italian: Joi.string(),
+      portuguese: Joi.string()
+    })
+  }),
+  bilibiliIds: Joi.when('challengeType', {
+    is: challengeTypes.video,
+    then: Joi.object().keys({
+      aid: Joi.number().required(),
+      bvid: Joi.string().required(),
+      cid: Joi.number().required()
+    })
+  }),
+  questions: Joi.when('challengeType', {
+    is: [
+      challengeTypes.video,
+      challengeTypes.multipleChoice,
+      challengeTypes.theOdinProject
+    ],
+    then: Joi.array().items(questionJoi).min(1).required(),
+    otherwise: Joi.array().length(0)
+  }),
+  quizzes: Joi.when('challengeType', {
+    is: challengeTypes.quiz,
+    then: Joi.array().items(quizJoi).min(1).required(),
+    otherwise: Joi.forbidden()
+  }),
+  required: Joi.array().items(
+    Joi.object().keys({
+      link: Joi.string(),
+      raw: Joi.bool(),
+      src: Joi.string(),
+      crossDomain: Joi.bool()
+    })
+  ),
+  assignments: Joi.when('challengeType', {
+    is: challengeTypes.dialogue,
+    then: Joi.array().items(Joi.string()).required(),
+    otherwise: Joi.array().items(Joi.string())
+  }),
+  scene: Joi.object().keys({
+    setup: setupJoi.required(),
+    commands: Joi.array()
+      .items(commandJoi)
+      .unique(
+        (a, b) =>
+          a.dialogue &&
+          b.dialogue &&
+          !(
+            (a.startTime < b.startTime &&
+              a.finishTime < b.finishTime &&
+              a.finishTime <= b.startTime) ||
+            (b.startTime < a.startTime &&
+              b.finishTime < a.finishTime &&
+              b.finishTime <= a.startTime)
+          )
+      )
+      .messages({
+        'array.unique': 'Dialogues must not have overlapping times.'
+      })
+  }),
+  solutions: Joi.array().items(Joi.array().items(fileJoi).min(1)),
+  superBlock: Joi.string().regex(slugWithSlashRE),
+  superOrder: Joi.number(),
+  suborder: Joi.number(),
+  hooks: Joi.object().keys({
+    beforeAll: Joi.string().allow(''),
+    beforeEach: Joi.string().allow(''),
+    afterEach: Joi.string().allow('')
+  }),
+  tests: Joi.array()
+    .items(
+      // public challenges
+      Joi.object().keys({
+        id: Joi.string().allow(''),
+        text: Joi.string().required(),
+        testString: Joi.string().allow('').required()
+      }),
+      // our tests used in certification verification
+      Joi.object().keys({
+        id: Joi.string().required(),
+        title: Joi.string().required()
+      })
+    )
+    .required(),
+  template: Joi.string().allow(''),
+  title: Joi.string().required(),
+  transcript: Joi.when('challengeType', {
+    is: [challengeTypes.generic, challengeTypes.video],
+    then: Joi.string()
+  }),
+  translationPending: Joi.bool().required(),
+  url: Joi.when('challengeType', {
+    is: [challengeTypes.codeAllyPractice, challengeTypes.codeAllyCert],
+    then: Joi.string().required()
+  }),
+  usesMultifileEditor: Joi.boolean()
+});
 
 exports.challengeSchemaValidator = () => {
   return challenge => schema.validate(challenge);

e2e/projects.spec.ts

@@ -27,7 +27,6 @@ interface Challenge {
   superBlock: string;
   dashedName: string;
   solutions: Solution[];
-  isPrivate?: boolean;
 }
 
 interface block {

tools/scripts/seed/__mocks__/curriculum.json

@@ -61,8 +61,7 @@
           {
             "title": "Challenge Nine",
             "block": "Block One",
-            "superBlock": "super-block-b",
+            "superBlock": "super-block-b"
-            "isPrivate": true
           },
           {
             "title": "Challenge Ten",