From 14ced4f271b51049dc353d73b45561648ad6c0c6 Mon Sep 17 00:00:00 2001 From: Sukka Date: Mon, 7 Apr 2025 16:28:17 +0800 Subject: [PATCH] fix: replace unpkg w/ jsdelivr & cdnjs (#59291) Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com> Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com> --- client/src/templates/Challenges/utils/build.ts | 2 +- .../challenges/_meta/react-and-redux/meta.json | 10 +++++----- curriculum/challenges/_meta/react/meta.json | 10 +++++----- .../lab-mood-board/673b3d6b7ef7318eef926d5a.md | 12 ++++++------ .../lab-reusable-footer/673b02b03134b04637bf7055.md | 12 ++++++------ .../6740495ba48aa94e5667b436.md | 6 +++--- .../67457ff2dc531fbed928a0f0.md | 6 +++--- .../6745c732dbeb7c04f346e6f7.md | 6 +++--- .../6745c7b06a0b530602cb63fa.md | 6 +++--- .../6745c89fba004707ded84453.md | 6 +++--- .../6745cebbf97ef2129f3b9bab.md | 6 +++--- .../6745d799beeb822076a4da9d.md | 6 +++--- .../6745d9df333efe2543a1f457.md | 6 +++--- .../6745dce846995b2a466594be.md | 6 +++--- .../6745de9ce925b92d72df713a.md | 6 +++--- .../6745e2aca895c935168e7d91.md | 12 ++++++------ .../674ef11f75254548672d998c.md | 6 +++--- .../674ef2d357676e50e4691658.md | 6 +++--- .../674ef2d357676e50e4691659.md | 6 +++--- .../674ef2d357676e50e469165a.md | 6 +++--- .../674ef2d357676e50e469165b.md | 6 +++--- .../674ef2d357676e50e469165c.md | 6 +++--- .../674ef2d357676e50e469165d.md | 12 ++++++------ knip.jsonc | 2 +- .../browser-scripts/typescript-worker.ts | 11 ++++++++--- 25 files changed, 92 insertions(+), 87 deletions(-) diff --git a/client/src/templates/Challenges/utils/build.ts b/client/src/templates/Challenges/utils/build.ts index 33b706d7bb8..ba035ae2e83 100644 --- a/client/src/templates/Challenges/utils/build.ts +++ b/client/src/templates/Challenges/utils/build.ts @@ -231,7 +231,7 @@ export async function buildDOMChallenge( const isMultifile = challengeFiles.length > 1; const requiresReact16 = required.some(({ src }) => - src?.includes('https://unpkg.com/react@16') + src?.includes('https://cdnjs.cloudflare.com/ajax/libs/react/16.') ); // I'm reasonably sure this is fine, but we need to migrate transformers to diff --git a/curriculum/challenges/_meta/react-and-redux/meta.json b/curriculum/challenges/_meta/react-and-redux/meta.json index 666ae59cb83..cd187b1f6cc 100644 --- a/curriculum/challenges/_meta/react-and-redux/meta.json +++ b/curriculum/challenges/_meta/react-and-redux/meta.json @@ -7,16 +7,16 @@ "template": "
${ source || '' }", "required": [ { - "src": "https://unpkg.com/react@16.4.0/umd/react.production.min.js" + "src": "https://cdnjs.cloudflare.com/ajax/libs/react/16.4.0/umd/react.production.min.js" }, { - "src": "https://unpkg.com/react-dom@16.4.0/umd/react-dom.production.min.js" + "src": "https://cdnjs.cloudflare.com/ajax/libs/react-dom/16.4.0/umd/react-dom.production.min.js" }, { - "src": "https://unpkg.com/react-dom@16.4.0/umd/react-dom-test-utils.production.min.js" + "src": "https://cdnjs.cloudflare.com/ajax/libs/react-dom/16.4.0/umd/react-dom-test-utils.production.min.js" }, { - "src": "https://unpkg.com/react-dom@16.4.0/umd/react-dom-server.browser.production.min.js" + "src": "https://cdnjs.cloudflare.com/ajax/libs/react-dom/16.4.0/umd/react-dom-server.browser.production.min.js" }, { "src": "https://cdnjs.cloudflare.com/ajax/libs/redux/3.7.2/redux.min.js" @@ -69,4 +69,4 @@ } ], "blockLayout": "legacy-challenge-list" -} \ No newline at end of file +} diff --git a/curriculum/challenges/_meta/react/meta.json b/curriculum/challenges/_meta/react/meta.json index 67ce7f9468a..bfbe5819106 100644 --- a/curriculum/challenges/_meta/react/meta.json +++ b/curriculum/challenges/_meta/react/meta.json @@ -7,16 +7,16 @@ "template": "
${ source || '' }", "required": [ { - "src": "https://unpkg.com/react@16.4.0/umd/react.production.min.js" + "src": "https://cdnjs.cloudflare.com/ajax/libs/react/16.4.0/umd/react.production.min.js" }, { - "src": "https://unpkg.com/react-dom@16.4.0/umd/react-dom.production.min.js" + "src": "https://cdnjs.cloudflare.com/ajax/libs/react-dom/16.4.0/umd/react-dom.production.min.js" }, { - "src": "https://unpkg.com/react-dom@16.4.0/umd/react-dom-test-utils.production.min.js" + "src": "https://cdnjs.cloudflare.com/ajax/libs/react-dom/16.4.0/umd/react-dom-test-utils.production.min.js" }, { - "src": "https://unpkg.com/react-dom@16.4.0/umd/react-dom-server.browser.production.min.js" + "src": "https://cdnjs.cloudflare.com/ajax/libs/react-dom/16.4.0/umd/react-dom-server.browser.production.min.js" } ], "superBlock": "front-end-development-libraries", @@ -211,4 +211,4 @@ } ], "blockLayout": "legacy-challenge-list" -} \ No newline at end of file +} diff --git a/curriculum/challenges/english/25-front-end-development/lab-mood-board/673b3d6b7ef7318eef926d5a.md b/curriculum/challenges/english/25-front-end-development/lab-mood-board/673b3d6b7ef7318eef926d5a.md index 368e88a2a3e..62fc2dd5d89 100644 --- a/curriculum/challenges/english/25-front-end-development/lab-mood-board/673b3d6b7ef7318eef926d5a.md +++ b/curriculum/challenges/english/25-front-end-development/lab-mood-board/673b3d6b7ef7318eef926d5a.md @@ -144,9 +144,9 @@ assert.exists(moodBoard); Mood Board - - - + + + - - + + + - - + + + - - + + + - + + - + - + + - + - + + - + - + + - + - + + - + - + + - + - + + - + - + + - + - + + - + - + + - + - + + - + - + + - + - + + - + - + + - + - + + - + - + + - + - + + - + - + + - + - + + - + - + + - +