gitadmin/freeCodeCamp
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git synced 2026-05-28 18:26:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(e2e, playwright): resolved mobile test failures on landing.spec.ts (#52474)

Browse Source 
Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
This commit is contained in:
Rahul Suresh
2023-12-06 11:02:26 -06:00
committed by GitHub
parent 645ea261e6
commit 2c62b06427
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/landing.spec.ts
+12 -5
View File
@@ -1,6 +1,6 @@
import { test, expect, type Page } from '@playwright/test'; import { expect, test, type Page } from '@playwright/test';
import translations from '../client/i18n/locales/english/translations.json';
import intro from '../client/i18n/locales/english/intro.json'; import intro from '../client/i18n/locales/english/intro.json';
import translations from '../client/i18n/locales/english/translations.json';
const landingPageElements = { const landingPageElements = {
heading: 'landing-header', heading: 'landing-header',
@@ -79,14 +79,21 @@ test('The landing-top & testimonial sections should contain call-to-action, and
} }
}); });
test("The landing-top should contain a descriptive text explaining the camper's image", async () => { test("The landing-top should contain a descriptive text explaining the camper's image", async ({
isMobile
}) => {
const campersImage = page.getByAltText(translations.landing['hero-img-alt']); const campersImage = page.getByAltText(translations.landing['hero-img-alt']);
const captionText = page.getByText( const captionText = page.getByText(
translations.landing['hero-img-description'] translations.landing['hero-img-description']
); );
await expect(campersImage).toBeVisible(); if (isMobile) {
await expect(captionText).toBeVisible(); await expect(campersImage).toBeHidden();
await expect(captionText).toBeHidden();
} else {
await expect(campersImage).toBeVisible();
await expect(captionText).toBeVisible();
}
}); });
test('The campers landing page figure is visible on desktop and hidden on mobile view', async ({ test('The campers landing page figure is visible on desktop and hidden on mobile view', async ({