gitadmin/freeCodeCamp
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git synced 2026-05-28 18:26:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use challengeTypes instead of magic numbers (#51373)

Browse Source
This commit is contained in:
Muhammed Mustafa
2023-08-28 19:07:49 +03:00
committed by GitHub
parent c96b8bd462
commit 39672e14f7
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
api/src/routes/challenge.ts
+4 -2
View File
@@ -86,7 +86,9 @@ export const challengeRoutes: FastifyPluginCallbackTypebox = (
}
const codeRoadChallenges = challenges.filter(
({ challengeType }) => challengeType === 12 || challengeType === 13
({ challengeType }) =>
challengeType === challengeTypes.codeAllyPractice ||
challengeType === challengeTypes.codeAllyCert
);
const challenge = codeRoadChallenges.find(challenge => {
@@ -131,7 +133,7 @@ export const challengeRoutes: FastifyPluginCallbackTypebox = (
challenge => challenge.id === challengeId
);
if (challengeType === 13 && !isCompleted) {
if (challengeType === challengeTypes.codeAllyCert && !isCompleted) {
const finalChallenge = {
id: challengeId,
completedDate