From 4919ac65fdeff7d0acb7a5581d19e69409d00c49 Mon Sep 17 00:00:00 2001
From: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
Date: Wed, 1 Nov 2023 22:13:19 +0700
Subject: [PATCH] fix(a11y): input not having associated label on MS trophy
 page (#52179)

---
 client/src/templates/Challenges/exam/show.tsx            | 1 -
 .../src/templates/Challenges/ms-trophy/link-ms-user.tsx  | 3 ++-
 e2e/link-ms-user.spec.ts                                 | 9 +++++++++
 3 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/client/src/templates/Challenges/exam/show.tsx b/client/src/templates/Challenges/exam/show.tsx
index f3b6700aadd..e9b4c780bc3 100644
--- a/client/src/templates/Challenges/exam/show.tsx
+++ b/client/src/templates/Challenges/exam/show.tsx
@@ -420,7 +420,6 @@ class ShowExam extends Component<ShowExamProps, ShowExamState> {
                       ({ answer, id }) => (
                         <label className='exam-answer-label' key={id}>
                           <input
-                            aria-label={t('aria.answer')}
                             checked={
                               userExamQuestions[currentQuestionIndex].answer
                                 .id === id
diff --git a/client/src/templates/Challenges/ms-trophy/link-ms-user.tsx b/client/src/templates/Challenges/ms-trophy/link-ms-user.tsx
index d52e3e46c8f..c6fbe2daafd 100644
--- a/client/src/templates/Challenges/ms-trophy/link-ms-user.tsx
+++ b/client/src/templates/Challenges/ms-trophy/link-ms-user.tsx
@@ -151,10 +151,11 @@ function LinkMsUser({
           <Spacer size='medium' />
           <form onSubmit={handleLinkUsername}>
             <FormGroup validationState={isValid ? 'success' : 'error'}>
-              <ControlLabel>
+              <ControlLabel htmlFor='transcript-link'>
                 <strong>{t('learn.ms.transcript-label')}</strong>
               </ControlLabel>
               <FormControl
+                id='transcript-link'
                 type='url'
                 onChange={handleInputChange}
                 placeholder='https://learn.microsoft.com/en-us/users/username/transcript/transcriptId'
diff --git a/e2e/link-ms-user.spec.ts b/e2e/link-ms-user.spec.ts
index 704747a85e8..fe3aa3451b6 100644
--- a/e2e/link-ms-user.spec.ts
+++ b/e2e/link-ms-user.spec.ts
@@ -64,5 +64,14 @@ test.describe('Link MS user component (unlinked signedIn user)', () => {
     const linkText6 = page.getByTestId('link-li-6-text');
     await expect(linkText6).toBeVisible();
     await expect(linkText6).toHaveText(translations.learn.ms['link-li-6']);
+
+    const transcriptLinkInput = page.getByLabel(
+      translations.learn.ms['transcript-label']
+    );
+    await expect(transcriptLinkInput).toBeVisible();
+    await expect(transcriptLinkInput).toHaveAttribute(
+      'placeholder',
+      'https://learn.microsoft.com/en-us/users/username/transcript/transcriptId'
+    );
   });
 });