refactor: disable naming-convenction rule (#51685)

.eslintrc.json

@@ -86,60 +86,7 @@
       "rules": {
         "import/no-unresolved": "off",
         "import/named": 0,
-        "@typescript-eslint/naming-convention": [
+        "@typescript-eslint/naming-convention": "off"
-          "error",
-          {
-            "selector": "default",
-            "format": ["camelCase"],
-            "leadingUnderscore": "allow",
-            "trailingUnderscore": "allow"
-          },
-          {
-            "selector": [
-              "classProperty",
-              "objectLiteralProperty",
-              "typeProperty",
-              "classMethod",
-              "objectLiteralMethod",
-              "typeMethod",
-              "accessor",
-              "enumMember"
-            ],
-            "format": null,
-            "modifiers": ["requiresQuotes"]
-          },
-          {
-            "selector": "variable",
-            "format": ["camelCase", "UPPER_CASE", "PascalCase"],
-            "leadingUnderscore": "allowSingleOrDouble",
-            "trailingUnderscore": "allow"
-          },
-          {
-            "selector": "typeLike",
-            "format": ["PascalCase"],
-            "custom": {
-              "regex": "^I[A-Z]|[a-zA-Z]Type$",
-              "match": false
-            }
-          },
-          {
-            "selector": "typeProperty",
-            "format": ["camelCase", "PascalCase"]
-          },
-          {
-            "selector": "objectLiteralProperty",
-            "format": ["camelCase", "PascalCase"],
-            "leadingUnderscore": "allowSingleOrDouble"
-          },
-          {
-            "selector": "function",
-            "format": ["camelCase", "PascalCase"]
-          },
-          {
-            "selector": "enumMember",
-            "format": ["PascalCase"]
-          }
-        ]
       }
     },
     {

api/jest.utils.ts

@@ -14,7 +14,6 @@ type Options = {
   sendCSRFToken: boolean;
 };
 
-/* eslint-disable @typescript-eslint/naming-convention */
 const requests = {
   GET: (resource: string) => request(fastifyTestInstance?.server).get(resource),
   POST: (resource: string) =>
@@ -23,7 +22,6 @@ const requests = {
   DELETE: (resource: string) =>
     request(fastifyTestInstance?.server).delete(resource)
 };
-/* eslint-enable @typescript-eslint/naming-convention */
 
 export const getCsrfToken = (setCookies: string[]): string | undefined => {
   const csrfSetCookie = setCookies.find(str => str.includes('csrf_token'));

api/src/routes/challenge.test.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
 /* eslint-disable @typescript-eslint/no-unsafe-assignment */
 import { omit } from 'lodash';

api/src/server.test.ts

@@ -5,7 +5,6 @@ jest.mock('./utils/env', () => {
   // eslint-disable-next-line @typescript-eslint/no-unsafe-return
   return {
     ...jest.requireActual('./utils/env'),
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     COOKIE_DOMAIN: '.freecodecamp.org'
   };
 });

client/src/components/Donation/paypal-button-script-loader.tsx

@@ -6,7 +6,6 @@ import { scriptLoader, scriptRemover } from '../../utils/script-loaders';
 
 import type { DonationApprovalData } from './types';
 
-/* eslint-disable @typescript-eslint/naming-convention */
 type PayPalButtonScriptLoaderProps = {
   isMinimalForm: boolean | undefined;
   clientId: string;
@@ -44,7 +43,6 @@ type PayPalButtonScriptLoaderProps = {
   };
   planId: string | null;
 };
-/* eslint-enable @typescript-eslint/naming-convention */
 
 type PayPalButtonScriptLoaderState = {
   isSdkLoaded: boolean;

client/src/components/Donation/paypal-button.tsx

@@ -98,7 +98,6 @@ class PaypalButton extends Component<PaypalButtonProps, PaypalButtonState> {
 
     return (
       <div className={'paypal-buttons-container'}>
-        {/* eslint-disable @typescript-eslint/naming-convention */}
         <PayPalButtonScriptLoader
           clientId={paypalClientId}
           createOrder={(
@@ -170,7 +169,6 @@ class PaypalButton extends Component<PaypalButtonProps, PaypalButtonState> {
             color: buttonColor
           }}
         />
-        {/* eslint-enable @typescript-eslint/naming-convention */}
       </div>
     );
   }

client/src/components/Donation/stripe-card-form.tsx

@@ -128,7 +128,6 @@ const StripeCardForm = ({
   ) => {
     if (stripe) {
       return stripe.confirmCardPayment(clientSecret, {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         payment_method: paymentMethod
       });
     }

client/src/components/growth-book/growth-book-redux-connector.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import React, { ReactNode, useEffect } from 'react';
 
 import { useFeature } from '@growthbook/growthbook-react';

client/src/components/growth-book/growth-book-wrapper.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import React, { ReactNode, useEffect } from 'react';
 import sha1 from 'sha-1';
 import {

client/src/components/helpers/avatar-renderer.tsx

@@ -29,7 +29,6 @@ function AvatarRenderer({
     if (
       // we probably have loads of records in the database with this default avatar URL set. To prevent making a request to the image we know will 404.
       !/freecodecamp\.com\/sample-image/.test(picture) &&
-      // eslint-disable-next-line @typescript-eslint/naming-convention
       isURL(picture, { require_protocol: true })
     ) {
       validationImage.src = picture;

client/src/components/settings/about.tsx

@@ -165,7 +165,6 @@ class AboutSettings extends Component<AboutProps, AboutState> {
 
   handlePictureChange = (e: React.FormEvent<HTMLInputElement>) => {
     const value = (e.target as HTMLInputElement).value.slice(0);
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     if (isURL(value, { require_protocol: true })) {
       this.validationImage.src = encodeURI(value);
     } else {

client/src/components/settings/portfolio.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import {
   Button,
   FormGroup,

client/src/declarations.d.ts

@@ -26,7 +26,6 @@ declare module 'sha-1' {
 // eslint-disable-next-line no-var
 declare var MathJax: {
   Hub: {
-    /* eslint-disable @typescript-eslint/naming-convention*/
     Config: (attributes: {
       tex2jax: {
         inlineMath: Array<string[]>;

client/src/templates/Challenges/utils/frame.ts

@@ -18,7 +18,6 @@ export interface Source {
 
 export interface Context {
   window?: Window &
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     typeof globalThis & { i18nContent?: i18n; __pyodide: unknown };
   document?: FrameDocument | PythonDocument;
   element: HTMLIFrameElement;

client/src/utils/solution-display-type.ts

@@ -2,7 +2,6 @@ import type { CompletedChallenge } from '../redux/prop-types';
 import { challengeTypes } from '../../../shared/config/challenge-types';
 import { maybeUrlRE } from '.';
 
-// eslint-disable-next-line @typescript-eslint/naming-convention
 type DisplayType =
   | 'none'
   | 'showMultifileProjectSolution'

client/utils/gatsby/layout-selector.test.tsx

@@ -27,8 +27,7 @@ function getComponentNameAndProps(
   pathname: string,
   pageContext?: { challengeMeta?: { block?: string; superBlock?: string } }
 ): NameAndProps {
-  // eslint-disable-next-line testing-library/render-result-naming-convention
+  const utils = ShallowRenderer.createRenderer();
-  const shallow = ShallowRenderer.createRenderer();
   const LayoutReactComponent = layoutSelector({
     element: { type: elementType, props: {}, key: '' },
     props: {
@@ -38,8 +37,8 @@ function getComponentNameAndProps(
       pageContext
     }
   });
-  shallow.render(<Provider store={store}>{LayoutReactComponent}</Provider>);
+  utils.render(<Provider store={store}>{LayoutReactComponent}</Provider>);
-  const view = shallow.getRenderOutput();
+  const view = utils.getRenderOutput();
   return {
     props: view.props.children.props as Record<string, unknown>,
     // eslint-disable-next-line @typescript-eslint/ban-ts-comment

tools/client-plugins/browser-scripts/index.d.ts

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
-
 import { PyodideInterface } from 'pyodide';
 
 export interface FrameDocument extends Document {

tools/client-plugins/browser-scripts/python-runner.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 // We have to specify pyodide.js because we need to import that file (not .mjs)
 // and 'import' defaults to .mjs
 import { loadPyodide, type PyodideInterface } from 'pyodide/pyodide.js';

tools/ui-components/src/drop-down/drop-down.tsx

@@ -18,7 +18,6 @@ type DropdownMenuProps = Props<
   MenuRenderPropArg,
   never,
   {
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __demoMode?: boolean;
   }
 >;