gitadmin/freeCodeCamp
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git synced 2026-05-28 18:26:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: only remove comments when specified in the test (#54372)

Browse Source
This commit is contained in:
Oliver Eyton-Williams
2024-04-26 03:03:43 +02:00
committed by GitHub
parent f8426e617e
commit adfb87e898
187 changed files with 299 additions and 340 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/client-plugins/browser-scripts/python-test-evaluator.ts
-2
View File
@@ -18,7 +18,6 @@ interface PythonRunEvent extends MessageEvent {
editableContents: string;
original: { [id: string]: string };
};
removeComments: boolean;
firstTest: unknown;
testString: string;
build: string;
@@ -64,7 +63,6 @@ void setupPyodide();
ctx.onmessage = async (e: PythonRunEvent) => {
const pyodide = await setupPyodide();
// TODO: Use removeComments when we have it
/* eslint-disable @typescript-eslint/no-unused-vars */
const code = (e.data.code.contents || '').slice();
const editableContents = (e.data.code.editableContents || '').slice();
tools/client-plugins/browser-scripts/test-evaluator.ts
+3 -12
View File
@@ -87,7 +87,6 @@ interface TestEvaluatorEvent extends MessageEvent {
editableContents: string;
original: { [id: string]: string };
};
removeComments: boolean;
firstTest: unknown;
testString: string;
build: string;
@@ -100,12 +99,8 @@ interface TestEvaluatorEvent extends MessageEvent {
/* Run the test if there is one. If not just evaluate the user code */
ctx.onmessage = async (e: TestEvaluatorEvent) => {
/* eslint-disable @typescript-eslint/no-unused-vars */
let code = (e.data?.code?.contents || '').slice();
code = e.data?.removeComments ? helpers.removeJSComments(code) : code;
let editableContents = (e.data?.code?.editableContents || '').slice();
editableContents = e.data?.removeComments
? helpers.removeJSComments(editableContents)
: editableContents;
const code = (e.data?.code?.contents || '').slice();
const editableContents = (e.data?.code?.editableContents || '').slice();
const assert = chai.assert;
const __helpers = helpers;
@@ -129,11 +124,7 @@ ctx.onmessage = async (e: TestEvaluatorEvent) => {
try {
// Logging is proxyed after the build to catch console.log messages
// generated during testing.
testResult = (await eval(`${
e.data?.removeComments
? helpers.removeJSComments(e.data.build)
: e.data.build
}
testResult = (await eval(`${e.data.build}
__utils.flushLogs();
__userCodeWasExecuted = true;
__utils.toggleProxyLogger(true);