chore(curriculum): minor clean up to daily challenges (#62095)

tools/challenge-helper-scripts/create-daily-challenges.ts

@@ -58,23 +58,32 @@ for (let i = 0; i < numberOfChallengesToCreate; i++) {
     );
   }
 
+  const challengeId = new ObjectID();
   const newChallengeNumber = numberOfJsChallenges + 1;
 
-  createDailyJsChallenge({ challengeNumber: newChallengeNumber, meta: jsMeta });
-  createDailyPyChallenge({ challengeNumber: newChallengeNumber, meta: pyMeta });
+  createDailyJsChallenge({
+    challengeId,
+    challengeNumber: newChallengeNumber,
+    meta: jsMeta
+  });
+  createDailyPyChallenge({
+    challengeId,
+    challengeNumber: newChallengeNumber,
+    meta: pyMeta
+  });
 }
 
 interface CreateDailyChallengeOptions {
+  challengeId: ObjectID;
   challengeNumber: number;
   meta: Meta;
 }
 
 function createDailyJsChallenge({
+  challengeId,
   challengeNumber,
   meta
 }: CreateDailyChallengeOptions) {
-  const challengeId = new ObjectID();
-
   const newMeta = {
     ...meta,
     challengeOrder: [
@@ -82,7 +91,7 @@ function createDailyJsChallenge({
       {
         // eslint-disable-next-line @typescript-eslint/no-base-to-string
         id: challengeId.toString(),
-        title: `JavaScript Challenge ${challengeNumber}`
+        title: `Challenge ${challengeNumber}: Placeholder`
       }
     ]
   };
@@ -104,11 +113,10 @@ function createDailyJsChallenge({
 }
 
 function createDailyPyChallenge({
+  challengeId,
   challengeNumber,
   meta
 }: CreateDailyChallengeOptions) {
-  const challengeId = new ObjectID();
-
   const newMeta = {
     ...meta,
     challengeOrder: [
@@ -116,7 +124,7 @@ function createDailyPyChallenge({
       {
         // eslint-disable-next-line @typescript-eslint/no-base-to-string
         id: challengeId.toString(),
-        title: `Python Challenge ${challengeNumber}`
+        title: `Challenge ${challengeNumber}: Placeholder`
       }
     ]
   };

tools/challenge-helper-scripts/helpers/get-challenge-template.ts

@@ -353,9 +353,9 @@ export const getDailyJavascriptChallengeTemplate = ({
   challengeNumber
 }: DailyCodingChallengeOptions) => `---
 id: ${challengeId.toString()}
-title: "JavaScript Challenge ${challengeNumber}: Placeholder"
+title: "Challenge ${challengeNumber}: Placeholder"
 challengeType: 28
-dashedName: javascript-challenge-${challengeNumber}
+dashedName: challenge-${challengeNumber}
 ---
 
 # --description--
@@ -396,9 +396,9 @@ export const getDailyPythonChallengeTemplate = ({
   challengeNumber
 }: DailyCodingChallengeOptions) => `---
 id: ${challengeId.toString()}
-title: "Python Challenge ${challengeNumber}: Placeholder"
+title: "Challenge ${challengeNumber}: Placeholder"
 challengeType: 29
-dashedName: python-challenge-${challengeNumber}
+dashedName: challenge-${challengeNumber}
 ---
 
 # --description--