gitadmin/freeCodeCamp
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git synced 2026-05-28 18:26:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: validate portfolio image correctly (#57084)

Browse Source
This commit is contained in:
Sem Bauke
2024-11-19 10:08:53 +01:00
committed by GitHub
parent d6ea481cbc
commit ef25dfee50
2 changed files with 72 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/portfolio.spec.ts
+11 -2
View File
@@ -63,12 +63,21 @@ test.describe('Add Portfolio Item', () => {
test('The image has validation', async ({ page }) => {
await page.getByLabel(translations.settings.labels.image).fill('T');
await expect(page.getByTestId('image-validation')).toContainText(
'URL must link directly to an image file'
'Please use a valid URL'
);
await page
.getByLabel(translations.settings.labels.image)
.fill('http://helloworld.com/image.png');
.fill(
'https://cdn.freecodecamp.org/universal/favicons/favicon-32x32.png'
);
await expect(page.getByTestId('image-validation')).toBeHidden();
await page
.getByLabel(translations.settings.labels.image)
.fill('https://cdn.freecodecamp.org/universal/favicons/favicon-32x32.pn');
await expect(page.getByTestId('image-validation')).toContainText(
'URL must link directly to an image file'
);
});
test('The description has validation', async ({ page }) => {