feat(client): delete generic success message in the alert (#49780)

* change the flash message in profileui endpoint

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

api/src/routes/settings.test.ts

@@ -62,7 +62,7 @@ describe('settingRoutes', () => {
 
         expect(response?.statusCode).toEqual(200);
         expect(response?.body).toEqual({
-          message: 'flash.updated-preferences',
+          message: 'flash.privacy-updated',
           type: 'success'
         });
         expect(user?.profileUI).toEqual(profileUI);

api/src/routes/settings.ts

@@ -30,7 +30,7 @@ export const settingRoutes: FastifyPluginCallbackTypebox = (
         }),
         response: {
           200: Type.Object({
-            message: Type.Literal('flash.updated-preferences'),
+            message: Type.Literal('flash.privacy-updated'),
             type: Type.Literal('success')
           }),
           500: Type.Object({
@@ -61,7 +61,7 @@ export const settingRoutes: FastifyPluginCallbackTypebox = (
         });
 
         return {
-          message: 'flash.updated-preferences',
+          message: 'flash.privacy-updated',
           type: 'success'
         } as const;
       } catch (err) {

client/i18n/locales/english/translations.json

@@ -594,7 +594,6 @@
     "not-authorized": "You are not authorized to continue on this route",
     "could-not-find": "We couldn't find what you were looking for. Please check and try again",
     "wrong-updating": "Something went wrong updating your account. Please check and try again",
-    "updated-preferences": "We have updated your preferences",
     "updated-about-me": "We have updated your personal information",
     "updated-socials": "We have updated your social links",
     "updated-sound": "We have updated your sound settings",

client/src/components/Flash/redux/flash-messages.ts

@@ -31,7 +31,6 @@ export enum FlashMessages {
   StartProjectErr = 'flash.start-project-err',
   TimelinePrivate = 'flash.timeline-private',
   TokenDeleted = 'flash.token-deleted',
-  UpdatedPreferences = 'flash.updated-preferences',
   UpdatedAboutMe = 'flash.updated-about-me',
   UpdatedSocials = 'flash.updated-socials',
   UpdatedSound = 'flash.updated-sound',

client/src/utils/tone/index.ts

@@ -46,7 +46,6 @@ const toneUrls = {
   [FlashMessages.StartProjectErr]: TRY_AGAIN,
   [FlashMessages.TimelinePrivate]: TRY_AGAIN,
   [FlashMessages.TokenDeleted]: CHAL_COMP,
-  [FlashMessages.UpdatedPreferences]: CHAL_COMP,
   [FlashMessages.UpdatedAboutMe]: CHAL_COMP,
   [FlashMessages.UpdatedKeyboardShortCuts]: CHAL_COMP,
   [FlashMessages.UpdatedPortfolio]: CHAL_COMP,