chore(deps): upgrade eslint (#50614)

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

.eslintrc.json

@@ -6,7 +6,12 @@
     "node": true,
     "jest": true
   },
-  "parser": "babel-eslint",
+  "parser": "@babel/eslint-parser",
+  "parserOptions": {
+    "babelOptions": {
+      "presets": ["@babel/preset-react"]
+    }
+  },
   "root": true,
   "extends": [
     "eslint:recommended",

client/src/components/profile/components/camper.tsx

@@ -121,7 +121,9 @@ function Camper({
               {t('profile.contributor')}
             </Link>
           </p>
-          <p className='text-center'>{joinArray(yearsTopContributor, t)}</p>
+          <p className='text-center'>
+            {joinArray(yearsTopContributor as string[], t)}
+          </p>
         </div>
       )}
       <br />

client/src/declarations.d.ts

@@ -26,6 +26,7 @@ declare module 'sha-1' {
 // eslint-disable-next-line no-var
 declare var MathJax: {
   Hub: {
+    /* eslint-disable @typescript-eslint/naming-convention*/
     Config: (attributes: {
       tex2jax: {
         inlineMath: Array<string[]>;

client/src/utils/scrollbar-width.ts

@@ -1,6 +1,6 @@
 import store from 'store';
 
 export function getScrollbarWidth(): number {
-  const storedWidth = parseInt(store.get('monacoScrollbarWidth'));
+  const storedWidth = store.get('monacoScrollbarWidth') as number;
   return storedWidth >= 5 || storedWidth <= 25 ? storedWidth : 5;
 }

package.json

@@ -114,16 +114,17 @@
     "@types/lodash": "4.14.195",
     "@types/node": "18.16.16",
     "@types/store": "2.0.2",
-    "@typescript-eslint/eslint-plugin": "^4.33.0",
+    "@typescript-eslint/eslint-plugin": "5.59.8",
+    "@typescript-eslint/parser": "5.59.8",
     "babel-jest": "29.5.0",
-    "babel-eslint": "^10.1.0",
+    "@babel/eslint-parser": "7.21.8",
     "babel-plugin-transform-imports": "2.0.0",
     "cross-env": "7.0.3",
     "cypress": "11.2.0",
     "cypress-plugin-stripe-elements": "1.0.2",
     "cypress-plugin-tab": "1.0.5",
     "docsify-cli": "4.4.4",
-    "eslint": "7.32.0",
+    "eslint": "8.42.0",
     "eslint-config-prettier": "8.8.0",
     "eslint-plugin-filenames-simple": "0.8.0",
     "eslint-plugin-import": "2.27.5",
@@ -132,7 +133,7 @@
     "eslint-plugin-no-only-tests": "2.6.0",
     "eslint-plugin-react": "7.32.2",
     "eslint-plugin-react-hooks": "4.6.0",
-    "eslint-plugin-testing-library": "4.12.4",
+    "eslint-plugin-testing-library": "5.11.0",
     "execa": "5.1.1",
     "husky": "8.0.3",
     "jest": "29.5.0",

tools/challenge-helper-scripts/repair-meta.ts

@@ -15,7 +15,9 @@ const repairMeta = async () => {
   // [id, title]
   const challengeOrder = fileList
     .map(file => matter.read(join(path, file)))
-    .sort((a, b) => sortByStepNum(a.data.dashedName, b.data.dashedName))
+    .sort((a, b) =>
+      sortByStepNum(a.data.dashedName as string, b.data.dashedName as string)
+    )
     .map(({ data }) => [data.id, data.title] as [string, string]);
   if (!challengeOrder.every(([, step]) => /Step \d+/.test(step))) {
     throw new Error(

tools/ui-components/src/form-group/form-group.test.tsx

@@ -14,7 +14,7 @@ describe('<FormGroup>', () => {
     );
 
     const element = screen.getByTestId('test-id');
-    expect(element.childElementCount).toBe(sameNumberOfChildren);
+    expect(element.childNodes.length).toBe(sameNumberOfChildren);
 
     const formGroupChildren = screen.getAllByTitle('Child');
     expect(formGroupChildren.length).toBe(sameNumberOfChildren);