gitadmin/freeCodeCamp
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git synced 2026-05-28 18:26:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(client): simplify search box text so less likely to ellipsis (#66851)

Browse Source 
Co-authored-by: m <m@ms-MacBook-Air.local>
This commit is contained in:
Quincy Larson
2026-04-07 16:54:41 -05:00
committed by GitHub
parent 2906599bef
commit 1fb20ded39
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/i18n/locales/english/translations.json
+2 -2
View File
@@ -916,8 +916,8 @@
"search": {
"label": "Search",
"placeholder": {
"default": "Search our news articles, tutorials, and books",
"numbered": "Search {{ roundedTotalRecords }}+ news articles, tutorials, and books"
"default": "Search our books and courses",
"numbered": "Search {{ roundedTotalRecords }}+ of our books and courses"
},
"see-results": "See all results for {{searchQuery}}",
"try": "Looking for something? Try the search bar on this page.",
client/tools/generate-search-placeholder.test.ts
+3 -3
View File
@@ -144,7 +144,7 @@ describe('Search bar placeholder tests:', () => {
if (clientLocale === 'english') {
describe('Placeholder strings', () => {
test('When the total number of hits is less than 100 the expected placeholder is generated', async () => {
const expected = 'Search our news articles, tutorials, and books';
const expected = 'Search our books and courses';
const placeholderText = await generateSearchPlaceholder({
mockRecordsNum: 99,
locale: 'english'
@@ -158,7 +158,7 @@ describe('Search bar placeholder tests:', () => {
mockRecordsNum: 100,
locale: 'english'
});
const expected = 'Search 100+ news articles, tutorials, and books';
const expected = 'Search 100+ of our books and courses';
expect(placeholderText).toEqual(expected);
});
@@ -168,7 +168,7 @@ describe('Search bar placeholder tests:', () => {
mockRecordsNum: 11000,
locale: 'english'
});
const expected = 'Search 11,000+ news articles, tutorials, and books';
const expected = 'Search 11,000+ of our books and courses';
expect(placeholderText).toEqual(expected);
});