gitadmin/freeCodeCamp
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git synced 2026-05-28 18:26:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(api-server): require github link for backend projects (#53512)

Browse Source 
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
This commit is contained in:
Shaun Hamilton
2024-02-13 17:15:15 +02:00
committed by GitHub
parent ba3d106c37
commit 2d9a279ad2
1 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
api-server/src/server/boot/challenge.js
+15 -3
View File
@@ -338,7 +338,7 @@ export async function createChallengeUrlResolver(
export function isValidChallengeCompletion(req, res, next) {
const {
body: { id, challengeType, solution }
body: { id, challengeType, solution, githubLink }
} = req;
// ToDO: Validate other things (challengeFiles, etc)
@@ -355,7 +355,15 @@ export function isValidChallengeCompletion(req, res, next) {
log('challengeType', challengeType, isNumeric(challengeType));
return res.status(403).json(isValidChallengeCompletionErrorMsg);
}
if ('solution' in req.body && !isURL(solution)) {
// If `backEndProject`:
// - `solution` needs to exist, but does not have to be valid URL
// - `githubLink` needs to exist and be valid URL
if (challengeType === challengeTypes.backEndProject) {
if (!solution || !isURL(githubLink + '')) {
log('isObjectId', id, ObjectID.isValid(id));
return res.status(403).json(isValidChallengeCompletionErrorMsg);
}
} else if ('solution' in req.body && !isURL(solution)) {
log('isObjectId', id, ObjectID.isValid(id));
return res.status(403).json(isValidChallengeCompletionErrorMsg);
}
@@ -427,7 +435,11 @@ async function projectCompleted(req, res, next) {
]);
completedChallenge.completedDate = Date.now();
if (!completedChallenge.solution) {
if (
!completedChallenge.solution ||
(completedChallenge.challengeType === challengeTypes.backEndProject &&
!completedChallenge.githubLink)
) {
return res.status(403).json({
type: 'error',
message: