gitadmin/freeCodeCamp
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git synced 2026-05-28 18:26:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(client): suppress babel transform warning (#57484)

Browse Source
This commit is contained in:
Oliver Eyton-Williams
2024-12-11 23:34:10 +01:00
committed by GitHub
parent b4e5a30cb3
commit 2f6f28ed14
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/templates/Challenges/rechallenge/transformers.js
+12 -1
View File
@@ -214,6 +214,7 @@ async function transformScript(documentElement, { useModules }) {
const scriptTags = documentElement.querySelectorAll('script');
scriptTags.forEach(script => {
const isBabel = script.type === 'text/babel';
const hasSource = !!script.src;
// TODO: make the use of JSX conditional on more than just the script type.
// It should only be used for React challenges since it would be confusing
// for learners to see the results of a transformation they didn't ask for.
@@ -228,8 +229,18 @@ async function transformScript(documentElement, { useModules }) {
// However, if we're importing modules, the type will be removed when the
// scripts are embedded in the HTML.
if (isBabel && !useModules) script.removeAttribute('type');
// We could use babel standalone to transform inline code in the preview,
// but that generates a warning that's shown to learner. By removing the
// type attribute and transforming the code we can avoid that warning.
if (isBabel && !hasSource) {
script.removeAttribute('type');
script.setAttribute('data-type', 'text/babel');
}
script.innerHTML = babelTransformCode(options)(script.innerHTML);
// Skip unnecessary transformations
script.innerHTML = script.innerHTML
? babelTransformCode(options)(script.innerHTML)
: '';
});
}