refactor: use environment, not .env, in ci (#65736)

.github/workflows/curriculum-i18n-submodule.yml

@@ -52,7 +52,7 @@ jobs:
 
       - name: Set Environment variables
         run: |
-          cp sample.env .env
+          sed '/^[[:space:]]*#/d; /^$/d' sample.env >> $GITHUB_ENV
 
       - name: Install node_modules
         run: pnpm install

.github/workflows/e2e-playwright.yml

@@ -54,7 +54,7 @@ jobs:
 
       - name: Set freeCodeCamp Environment Variables
         run: |
-          cp sample.env .env
+          sed '/^[[:space:]]*#/d; /^$/d' sample.env >> $GITHUB_ENV
 
       - name: Install and Build
         run: |
@@ -153,7 +153,8 @@ jobs:
 
       - name: Set freeCodeCamp Environment Variables (needed by api)
         run: |
-          cp sample.env .env
+          sed '/^[[:space:]]*#/d; /^$/d' sample.env >> $GITHUB_ENV
+          cp sample.env .env # for docker compose
 
       - name: Install playwright dependencies
         run: npx playwright install --with-deps

.github/workflows/i18n-validate-builds.yml

@@ -41,7 +41,7 @@ jobs:
 
       - name: Set freeCodeCamp Environment Variables
         run: |
-          cp sample.env .env
+          sed '/^[[:space:]]*#/d; /^$/d' sample.env >> $GITHUB_ENV
 
       - name: Install Dependencies
         run: pnpm install

.github/workflows/i18n-validate-prs.yml

@@ -37,7 +37,7 @@ jobs:
 
       - name: Set freeCodeCamp Environment Variables
         run: |
-          cp sample.env .env
+          sed '/^[[:space:]]*#/d; /^$/d' sample.env >> $GITHUB_ENV
 
       - name: Install Dependencies
         run: pnpm install

.github/workflows/node.js-tests.yml

@@ -45,6 +45,9 @@ jobs:
             exit 1
           fi
 
+      - name: Check format of sample.env
+        run: docker run --rm -v `pwd`:/app -w /app dotenvlinter/dotenv-linter check --ignore-checks UnorderedKey sample.env
+
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6
         with:
@@ -64,8 +67,8 @@ jobs:
 
       - name: Set Environment variables
         run: |
-          cp sample.env .env
-          cat .env
+          sed '/^[[:space:]]*#/d; /^$/d' sample.env >> $GITHUB_ENV
+          cat sample.env
 
       - name: Install node_modules
         run: pnpm install
@@ -116,7 +119,7 @@ jobs:
 
       - name: Set freeCodeCamp Environment Variables
         run: |
-          cp sample.env .env
+          sed '/^[[:space:]]*#/d; /^$/d' sample.env >> $GITHUB_ENV
 
       - name: Install and Build
         run: |
@@ -158,8 +161,8 @@ jobs:
 
       - name: Set Environment variables
         run: |
-          cp sample.env .env
-          cat .env
+          sed '/^[[:space:]]*#/d; /^$/d' sample.env >> $GITHUB_ENV
+          cat sample.env
 
       - name: Start MongoDB
         run: docker compose -f docker/docker-compose.yml up -d
@@ -210,9 +213,9 @@ jobs:
 
       - name: Set Environment variables
         run: |
-          cp sample.env .env
+          sed '/^[[:space:]]*#/d; /^$/d' sample.env >> $GITHUB_ENV
           echo 'SHOW_UPCOMING_CHANGES=true' >> .env
-          cat .env
+          cat sample.env
 
       - name: Start MongoDB
         run: docker compose -f docker/docker-compose.yml up -d
@@ -265,8 +268,8 @@ jobs:
 
       - name: Set Environment variables
         run: |
-          cp sample.env .env
-          cat .env
+          sed '/^[[:space:]]*#/d; /^$/d' sample.env >> $GITHUB_ENV
+          cat sample.env
 
       - name: Start MongoDB
         uses: supercharge/mongodb-github-action@315db7fe45ac2880b7758f1933e6e5d59afd5e94 # 1.12.1

api/src/utils/env.ts

@@ -8,7 +8,11 @@ const __dirname = path.dirname(fileURLToPath(import.meta.url));
 const envPath = path.resolve(__dirname, '../../../.env');
 const { error } = config({ path: envPath });
 
-if (error && process.env.FREECODECAMP_NODE_ENV !== 'production') {
+if (
+  error &&
+  process.env.FREECODECAMP_NODE_ENV == 'production' &&
+  process.env.NODE_ENV !== 'test'
+) {
   console.warn(`
   ----------------------------------------------------
   Warning: .env file not found.

api/turbo.json

@@ -39,7 +39,41 @@
       ]
     },
     "test": {
-      "passThroughEnv": ["VITEST_WORKER_ID"]
+      "passThroughEnv": ["VITEST_WORKER_ID"],
+      "env": [
+        "API_LOCATION",
+        "AUTH0_CLIENT_ID",
+        "AUTH0_CLIENT_SECRET",
+        "AUTH0_DOMAIN",
+        "COOKIE_DOMAIN",
+        "COOKIE_SECRET",
+        "DEPLOYMENT_ENV",
+        "DEPLOYMENT_VERSION",
+        "EMAIL_PROVIDER",
+        "FCC_API_LOG_LEVEL",
+        "FCC_API_LOG_TRANSPORT",
+        "FCC_ENABLE_DEV_LOGIN_MODE",
+        "FCC_ENABLE_SENTRY_ROUTES",
+        "FCC_ENABLE_SHADOW_CAPTURE",
+        "FCC_ENABLE_SWAGGER_UI",
+        "FCC_ENABLE_TEST_LOGGING",
+        "FREECODECAMP_NODE_ENV",
+        "GROWTHBOOK_FASTIFY_API_HOST",
+        "GROWTHBOOK_FASTIFY_CLIENT_KEY",
+        "HOME_LOCATION",
+        "HOST",
+        "JWT_SECRET",
+        "MAILPIT_HOST",
+        "NODE_ENV",
+        "PORT",
+        "SENTRY_DSN",
+        "SENTRY_ENVIRONMENT",
+        "SES_ID",
+        "SES_REGION",
+        "SES_SECRET",
+        "SHOW_UPCOMING_CHANGES",
+        "STRIPE_SECRET_KEY"
+      ]
     }
   }
 }

curriculum/src/config.ts

@@ -17,7 +17,7 @@ export function testedLang() {
       Before the site can be built, this language needs to be manually approved`);
     }
   } else {
-    throw Error('LOCALE must be set for testing');
+    throw Error('CURRICULUM_LOCALE must be set for testing');
   }
 }
 

curriculum/turbo.json

@@ -13,6 +13,9 @@
     "test-content": {
       "passThroughEnv": ["VITEST_POOL_ID", "PUPPETEER_WS_ENDPOINT"],
       "env": ["FCC_*", "CURRICULUM_LOCALE", "SHOW_UPCOMING_CHANGES"]
+    },
+    "lint": {
+      "env": ["CURRICULUM_LOCALE"]
     }
   }
 }