fix(curriculum):Added return inside map from step-25 to 45 and test for checking space between isCaptain and name (#56918)

This commit is contained in:
Kamal Singh
2024-10-29 16:20:02 +05:30
committed by GitHub
parent 46619eb00f
commit 5afa16aa31
21 changed files with 60 additions and 52 deletions
@@ -7,18 +7,18 @@ dashedName: step-25
# --description--
Inside the body of the callback function, you will need to add template literals ``` `` ``` which will contain the HTML content for the player cards.
Inside the body of the callback function, you will need to return a template literal ``` `` ``` which will contain the HTML content for the player cards.
Inside the template literals, add an empty `div` with a class of `"player-card"`.
# --hints--
You should use template literals to add an empty `div` with a class of `"player-card"`.
The `map` callback should return a template literal that contains an empty `div` with a class of `"player-card"`.
```js
assert.match(code, /`\s*<div\s+class=("|')\s*player-card\s*\1\s*>\s*<\/div>\s*`\s*/)
assert.match(code, /return\s*`\s*<div\s+class=("|')\s*player-card\s*\1\s*>\s*<\/div>\s*`\s*/)
```
@@ -460,7 +460,7 @@ const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr.map(
({ name, position, number, isCaptain, nickname }) => {
`
return `
<div class="player-card">
</div>
@@ -19,6 +19,14 @@ You should use a ternary operator to check if `isCaptain` is true and return `"(
assert.match(code, /\s*<h2\s*>\s*\$\{isCaptain(\s*===\s*true)?\s*\?\s*('|"|`)\(Captain\)\2\s*:\s*('|"|`)\3\}\s*\${\s*name\s*}\s*<\/h2>\s*/)
```
You should give a space between `"(Captain)"` and `name`.
```js
playerCards.innerHTML = '';
setPlayerCards([{name: "Diego Maradona", isCaptain: true}])
assert.equal(document.querySelector(".player-card h2").innerText, '(Captain) Diego Maradona')
```
# --seed--
## --seed-contents--
@@ -452,7 +460,7 @@ const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr.map(
({ name, position, number, isCaptain, nickname }) => {
`
return `
<div class="player-card">
<h2>${name}</h2>
</div>
@@ -456,7 +456,7 @@ const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr.map(
({ name, position, number, isCaptain, nickname }) => {
`
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
@@ -456,7 +456,7 @@ const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr.map(
({ name, position, number, isCaptain, nickname }) => {
`
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
@@ -456,7 +456,7 @@ const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr.map(
({ name, position, number, isCaptain, nickname }) => {
`
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
@@ -464,7 +464,7 @@ const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr.map(
({ name, position, number, isCaptain, nickname }) => {
`
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
@@ -459,7 +459,7 @@ const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr.map(
({ name, position, number, isCaptain, nickname }) => {
`
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
@@ -461,15 +461,15 @@ headCoach.textContent = coachName;
const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr
.map(
({ name, position, number, isCaptain, nickname }) =>
`
({ name, position, number, isCaptain, nickname }) => {
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
<p>Number: ${number}</p>
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
</div>
`
` }
)
.join("");
};
@@ -449,15 +449,15 @@ headCoach.textContent = coachName;
const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr
.map(
({ name, position, number, isCaptain, nickname }) =>
`
({ name, position, number, isCaptain, nickname }) => {
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
<p>Number: ${number}</p>
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
</div>
`
` }
)
.join("");
};
@@ -451,15 +451,15 @@ headCoach.textContent = coachName;
const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr
.map(
({ name, position, number, isCaptain, nickname }) =>
`
({ name, position, number, isCaptain, nickname }) => {
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
<p>Number: ${number}</p>
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
</div>
`
` }
)
.join("");
};
@@ -463,15 +463,15 @@ headCoach.textContent = coachName;
const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr
.map(
({ name, position, number, isCaptain, nickname }) =>
`
({ name, position, number, isCaptain, nickname }) => {
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
<p>Number: ${number}</p>
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
</div>
`
` }
)
.join("");
};
@@ -461,15 +461,15 @@ headCoach.textContent = coachName;
const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr
.map(
({ name, position, number, isCaptain, nickname }) =>
`
({ name, position, number, isCaptain, nickname }) => {
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
<p>Number: ${number}</p>
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
</div>
`
` }
)
.join("");
};
@@ -449,15 +449,15 @@ headCoach.textContent = coachName;
const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr
.map(
({ name, position, number, isCaptain, nickname }) =>
`
({ name, position, number, isCaptain, nickname }) => {
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
<p>Number: ${number}</p>
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
</div>
`
` }
)
.join("");
};
@@ -489,15 +489,15 @@ headCoach.textContent = coachName;
const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr
.map(
({ name, position, number, isCaptain, nickname }) =>
`
({ name, position, number, isCaptain, nickname }) => {
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
<p>Number: ${number}</p>
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
</div>
`
` }
)
.join("");
};
@@ -483,15 +483,15 @@ headCoach.textContent = coachName;
const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr
.map(
({ name, position, number, isCaptain, nickname }) =>
`
({ name, position, number, isCaptain, nickname }) => {
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
<p>Number: ${number}</p>
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
</div>
`
` }
)
.join("");
};
@@ -483,15 +483,15 @@ headCoach.textContent = coachName;
const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr
.map(
({ name, position, number, isCaptain, nickname }) =>
`
({ name, position, number, isCaptain, nickname }) => {
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
<p>Number: ${number}</p>
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
</div>
`
` }
)
.join("");
};
@@ -483,15 +483,15 @@ headCoach.textContent = coachName;
const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr
.map(
({ name, position, number, isCaptain, nickname }) =>
`
({ name, position, number, isCaptain, nickname }) => {
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
<p>Number: ${number}</p>
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
</div>
`
` }
)
.join("");
};
@@ -459,15 +459,15 @@ headCoach.textContent = coachName;
const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr
.map(
({ name, position, number, isCaptain, nickname }) =>
`
({ name, position, number, isCaptain, nickname }) => {
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
<p>Number: ${number}</p>
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
</div>
`
` }
)
.join("");
};
@@ -935,15 +935,15 @@ headCoach.textContent = coachName;
const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr
.map(
({ name, position, number, isCaptain, nickname }) =>
`
({ name, position, number, isCaptain, nickname }) => {
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
<p>Number: ${number}</p>
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
</div>
`
` }
)
.join("");
};
@@ -474,15 +474,15 @@ headCoach.textContent = coachName;
const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr
.map(
({ name, position, number, isCaptain, nickname }) =>
`
({ name, position, number, isCaptain, nickname }) => {
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
<p>Number: ${number}</p>
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
</div>
`
` }
)
.join("");
};
@@ -449,15 +449,15 @@ headCoach.textContent = coachName;
const setPlayerCards = (arr = players) => {
playerCards.innerHTML += arr
.map(
({ name, position, number, isCaptain, nickname }) =>
`
({ name, position, number, isCaptain, nickname }) => {
return `
<div class="player-card">
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
<p>Position: ${position}</p>
<p>Number: ${number}</p>
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
</div>
`
` }
)
.join("");
};