gitadmin/freeCodeCamp
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git synced 2026-05-28 18:26:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(api): improve log statements (#59992)

Browse Source
This commit is contained in:
Mrugesh Mohapatra
2025-04-25 16:04:03 +05:30
committed by GitHub
parent 464181b3b8
commit a905083bf8
4 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
api/src/plugins/error-handling.test.ts
+8 -2
View File
@@ -170,7 +170,10 @@ describe('errorHandling', () => {
url: '/test'
});
expect(logSpy).toHaveBeenCalledWith(Error('a very bad thing happened'));
expect(logSpy).toHaveBeenCalledWith(
Error('a very bad thing happened'),
'Error in request'
);
});
it('should call fastify.log.warn when a bad request error occurs', async () => {
@@ -181,7 +184,10 @@ describe('errorHandling', () => {
url: '/test-bad-request'
});
expect(logSpy).toHaveBeenCalledWith(Error('a very bad thing happened'));
expect(logSpy).toHaveBeenCalledWith(
Error('a very bad thing happened'),
'CSRF error in request'
);
});
it('should NOT log when a CSRF error is thrown', async () => {
api/src/plugins/error-handling.ts
+2 -2
View File
@@ -39,9 +39,9 @@ const errorHandling: FastifyPluginCallback = (fastify, _options, done) => {
if (!isCSRFError) {
if (reply.statusCode >= 500) {
logger.error(error);
logger.error(error, 'Error in request');
} else {
logger.warn(error);
logger.warn(error, 'CSRF error in request');
}
}
api/src/routes/protected/challenge.ts
+3 -3
View File
@@ -187,7 +187,7 @@ export const challengeRoutes: FastifyPluginCallbackTypebox = (
}
} catch (error) {
// TODO(Post-MVP): don't catch, just let Sentry handle this.
logger.error(error);
logger.error(error, 'Error submitting coderoad challenge');
fastify.Sentry.captureException(error);
void reply.code(400);
return {
@@ -669,7 +669,7 @@ export const challengeRoutes: FastifyPluginCallbackTypebox = (
completedDate
};
} catch (error) {
logger.error(error);
logger.error(error, 'Error submitting Microsoft trophy challenge');
fastify.Sentry.captureException(error);
void reply.code(500);
return {
@@ -884,7 +884,7 @@ export const challengeRoutes: FastifyPluginCallbackTypebox = (
examResults
};
} catch (error) {
logger.error(error);
logger.error(error, 'Error submitting exam challenge');
fastify.Sentry.captureException(error);
void reply.code(500);
return {
api/src/routes/protected/donate.ts
+2 -4
View File
@@ -90,8 +90,7 @@ export const donateRoutes: FastifyPluginCallbackTypebox = (
isDonating: true
} as const;
} catch (error) {
logger.error(`User ${req.user?.id} failed to donate`);
logger.error(error);
logger.error(error, `User ${req.user?.id} failed to donate`);
fastify.Sentry.captureException(error);
void reply.code(500);
return {
@@ -227,8 +226,7 @@ export const donateRoutes: FastifyPluginCallbackTypebox = (
isDonating: true
});
} catch (error) {
logger.error(`User ${req.user?.id} failed to donate`);
logger.error(error);
logger.error(error, `User ${req.user?.id} failed to donate`);
fastify.Sentry.captureException(error);
void reply.code(500);
return reply.send({