gitadmin/freeCodeCamp
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git synced 2026-05-28 18:26:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: aa test supporting copy and background (#57019)

Browse Source
This commit is contained in:
Ahmad Abdolsaheb
2024-11-04 17:26:13 +03:00
committed by GitHub
parent 00a880411e
commit cdda73161e
4 changed files with 23 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/components/landing/components/landing-top-b.tsx
+2 -7
View File
@@ -63,8 +63,9 @@ function LandingTop(): JSX.Element {
id='content-start'
className='mega-heading'
data-test-label='landing-header'
data-playwright-test-label='landing-big-heading-1'
>
{t('landing.big-heading-1-b')}
{t('landing.big-heading-1')}
</h1>
<p
className='mega-heading'
@@ -78,12 +79,6 @@ function LandingTop(): JSX.Element {
>
{t('landing.big-heading-3')}
</p>
<p
className='mega-heading gradient-foreground'
data-playwright-test-label='landing-big-heading-4'
>
{t('landing.big-heading-4')}
</p>
<LogoRow />
<Spacer size='m' />
<BigCallToAction />
client/src/components/landing/landing.css
+1 -1
View File
@@ -219,7 +219,7 @@ figcaption.caption {
/* AB testing styles */
.landing-page-b .mega-heading {
font-size: 2.5rem;
font-size: 2.2rem;
margin: 0px 0px 2rem;
font-weight: 700;
line-height: 2rem;
client/src/pages/index.tsx
+1 -1
View File
@@ -69,7 +69,7 @@ function IndexPage({
'show-benefits',
false
);
growthbook.getFeatureValue('landing-aa-test', false);
return (
<>
<SEO title={t('metaTags:title')} />
e2e/landing.spec.ts
+19 -38
View File
@@ -49,28 +49,7 @@ test.describe('Landing Top - Variation B', () => {
await goToLandingPage(page);
});
test('The component Landing-top renders correctly', async ({ page }) => {
await expect(
page
.getByRole('heading', { level: 1 })
.filter({ hasText: `${translations.landing['big-heading-1-b']}` })
).toBeVisible();
const landingHeading2 = page.getByTestId('landing-big-heading-2');
await expect(landingHeading2).toHaveText(
translations.landing['big-heading-2']
);
const landingHeading3 = page.getByTestId('landing-big-heading-3');
await expect(landingHeading3).toHaveText(
translations.landing['big-heading-3']
);
const landingHeading4 = page.getByTestId('landing-big-heading-4');
await expect(landingHeading4).toHaveText(
translations.landing['big-heading-4']
);
test('The supporting copy renders correctly', async ({ page }) => {
const landingH2Heading = page.getByTestId('landing-h2-heading-b');
await expect(landingH2Heading).toHaveText(
translations.landing['h2-heading-b'].replace(/<\/?strong>/g, '')
@@ -99,22 +78,7 @@ test.describe('Landing Top - Variation A', () => {
await goToLandingPage(page);
});
test('The component Landing-top renders correctly', async ({ page }) => {
const landingHeading1 = page.getByTestId('landing-big-heading-1');
await expect(landingHeading1).toHaveText(
translations.landing['big-heading-1']
);
const landingHeading2 = page.getByTestId('landing-big-heading-2');
await expect(landingHeading2).toHaveText(
translations.landing['big-heading-2']
);
const landingHeading3 = page.getByTestId('landing-big-heading-3');
await expect(landingHeading3).toHaveText(
translations.landing['big-heading-3']
);
test('The supporting copy renders correctly', async ({ page }) => {
const landingH2Heading = page.getByTestId('landing-h2-heading');
await expect(landingH2Heading).toHaveText(
translations.landing['h2-heading']
@@ -149,6 +113,23 @@ test.describe('Landing Page', () => {
}
});
test('The headline renders correctly', async ({ page }) => {
const landingHeading1 = page.getByTestId('landing-big-heading-1');
await expect(landingHeading1).toHaveText(
translations.landing['big-heading-1']
);
const landingHeading2 = page.getByTestId('landing-big-heading-2');
await expect(landingHeading2).toHaveText(
translations.landing['big-heading-2']
);
const landingHeading3 = page.getByTestId('landing-big-heading-3');
await expect(landingHeading3).toHaveText(
translations.landing['big-heading-3']
);
});
test('Hero image should have an alt and a description', async ({
isMobile,
page